Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated dashboard templates/queries with correct prometheus metr… #1481

Merged

Conversation

ja14000
Copy link
Contributor

@ja14000 ja14000 commented Aug 9, 2024

zk_avg_latency renamed to ClickHouseAsyncMetrics_KeeperAvgLatency
zk_max_latency renamed to ClickHouseAsyncMetrics_KeeperMaxLatency
zk_num_alive_connections renamed to ClickHouseMetrics_KeeperAliveConnections
zk_packets_sent renamed to ClickHouseAsyncMetrics_KeeperPacketsSent
zk_packets_received renamed to ClickHouseAsyncMetrics_KeeperPacketsReceived
zk_znode_count renamed to ClickHouseAsyncMetrics_KeeperZnodeCount
zk_watch_count renamed to ClickHouseAsyncMetrics_KeeperWatchCount
zk_ephemerals_count renamed to ClickHouseAsyncMetrics_KeeperEphemeralsCount
zk_approximate_data_size renamed to ClickHouseAsyncMetrics_KeeperApproximateDataSize
zk_outstanding_requests renamed to ClickHouseMetrics_KeeperOutstandingRequests
zk_open_file_descriptor_count renamed to ClickHouseAsyncMetrics_KeeperOpenFileDescriptorCount

This resolves the issue described here and the dashboard now works normally.

image

…ic names

Signed-off-by: John Awogboro <ja14000@users.noreply.github.com>>
@ja14000 ja14000 force-pushed the fix-clickhouse-keeper-grafana-dashboard branch from fc62965 to adab290 Compare August 9, 2024 11:43
@Slach Slach self-requested a review August 9, 2024 12:14
Copy link
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contribution!

Looks like you have different Prometheus pod scraping config with different label name conversions

look
https://github.com/Altinity/clickhouse-operator/blob/0.24.0/deploy/prometheus/prometheus-template.yaml#L48-L54

Could you return label names back?

grafana-dashboard/ClickHouseKeeper_dashboard.json Outdated Show resolved Hide resolved
grafana-dashboard/ClickHouseKeeper_dashboard.json Outdated Show resolved Hide resolved
grafana-dashboard/ClickHouseKeeper_dashboard.json Outdated Show resolved Hide resolved
grafana-dashboard/ClickHouseKeeper_dashboard.json Outdated Show resolved Hide resolved
@ja14000
Copy link
Contributor Author

ja14000 commented Aug 9, 2024

Thank you so much for contribution!

Looks like you have different Prometheus pod scraping config with different label name conversions

look https://github.com/Altinity/clickhouse-operator/blob/0.24.0/deploy/prometheus/prometheus-template.yaml#L48-L54

Could you return label names back?

Thanks for taking the time to review this, I've restored the original label names, and updated the template queries for pod_name and container_name with the ones that you provided.

@ja14000 ja14000 force-pushed the fix-clickhouse-keeper-grafana-dashboard branch from 00aaffb to ea16538 Compare August 9, 2024 18:49
Signed-off-by: John Awogboro <ja14000@users.noreply.github.com>
@ja14000 ja14000 force-pushed the fix-clickhouse-keeper-grafana-dashboard branch from ea16538 to 9f034f2 Compare August 9, 2024 19:00
@Slach Slach self-requested a review August 11, 2024 15:41
@Slach Slach merged commit 4763e9d into Altinity:0.24.0 Aug 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants