update helm chart generator to treat config.yaml as yaml in values #1317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some of the concerns raised in #1138 and leaves the contents of
config.yaml
as YAML invalues.yaml
, enabling users to change a single value without the need to copy the rest of its contents over to their own values.Users already using a string for their
config.yaml
value should not be affected, as the template partial responsible for rendering the data treats any top-level string value as before. This behavior was also necessary to retain in order to render the ConfigMaps with non-YAML data.next-release
branch, not intomaster
branch1. More info