Merge pull request #1168 from jewelzqiu/fix-reconcile-crash

fix crash when reconcilePVC() failed
Altinity · Jun 5, 2023 · c852d03 · c852d03
2 parents 0cf969b + f488d22
commit c852d03
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/controller/chi/worker-reconciler.go b/pkg/controller/chi/worker-reconciler.go
@@ -801,14 +801,14 @@ func (w *worker) reconcilePVCs(ctx context.Context, host *chiV1.ChiHost) error {
 			}
 		}
 
-		pvc, err = w.reconcilePVC(ctx, pvc, host, volumeClaimTemplate)
+		newPvc, err := w.reconcilePVC(ctx, pvc, host, volumeClaimTemplate)
 		if err != nil {
 			w.a.M(host).F().Error("ERROR unable to reconcile PVC(%s/%s) err: %v", namespace, pvcName, err)
 			w.task.registryFailed.RegisterPVC(pvc.ObjectMeta)
 			return
 		}
 
-		w.task.registryReconciled.RegisterPVC(pvc.ObjectMeta)
+		w.task.registryReconciled.RegisterPVC(newPvc.ObjectMeta)
 	})
 
 	return nil