Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add $columnsMs macro, #695

Merged
merged 3 commits into from
Dec 19, 2024
Merged

add $columnsMs macro, #695

merged 3 commits into from
Dec 19, 2024

Conversation

Slach
Copy link
Collaborator

@Slach Slach commented Dec 19, 2024

fix #430

Signed-off-by: Eugene Klimov <eklimov@altinity.com>
Signed-off-by: Eugene Klimov <eklimov@altinity.com>
Signed-off-by: Eugene Klimov <eklimov@altinity.com>
@Slach Slach merged commit 2bddea7 into master Dec 19, 2024
3 checks passed
@coveralls
Copy link

coveralls commented Dec 19, 2024

Pull Request Test Coverage Report for Build 12408355755

Details

  • 54 of 70 (77.14%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 75.945%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/datasource/scanner/scanner.ts 2 4 50.0%
src/datasource/sql-query/sql-query-macros.ts 17 20 85.0%
pkg/eval_query.go 35 46 76.09%
Totals Coverage Status
Change from base Build 12405844441: -0.2%
Covered Lines: 3526
Relevant Lines: 4436

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implementation macro $columnsMs
2 participants