Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for float and timestamp64 default values. #689

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Conversation

antip00
Copy link
Collaborator

@antip00 antip00 commented Dec 9, 2024

fix #679

@antip00
Copy link
Collaborator Author

antip00 commented Dec 9, 2024

After specifying default value for float column timestamp type it is not preselected for panel and it is not in Timestamp Column dropdown.

Screenshot from 2024-12-09 19-39-46
Screenshot from 2024-12-09 19-40-03
Screenshot from 2024-12-09 19-40-07

@Slach Slach added this to the 3.3.1 milestone Dec 16, 2024
Signed-off-by: Eugene Klimov <eklimov@altinity.com>
Signed-off-by: Eugene Klimov <eklimov@altinity.com>
Signed-off-by: Eugene Klimov <eklimov@altinity.com>
@coveralls
Copy link

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12396083399

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 76.133%

Files with Coverage Reduction New Missed Lines %
src/views/QueryEditor/helpers/initializeQueryDefaults.ts 1 95.45%
src/datasource/datasource.ts 6 50.39%
Totals Coverage Status
Change from base Build 12278256209: 0.4%
Covered Lines: 3499
Relevant Lines: 4393

💛 - Coveralls

@Slach Slach merged commit 6bb4bc1 into master Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e tests for TimeStamp64_X and Float
3 participants