Add Ars Nouveau compat

[PersiflageTheNinth]

Proposed Changes

• support for the pedestalItems recipe key in Ars Nouveau Enchanting Apparatus and Imbuement recipes
• support for the inputItems recipe key in Ars Nouveau Glyph recipes
• support for the reagent recipe key in Ars Nouveau Enchanting Apparatus

[LLytho]

Thanks for the PR. Will test it later.

Based on:

  "pedestalItems": [
    {
      "item": {
        "tag": "forge:storage_blocks/redstone"
      }
    },
    {
      "item": {
        "tag": "forge:storage_blocks/redstone"
      }
    },
    {
      "item": {
        "item": "minecraft:diamond_pickaxe"
      }
    },
    {
      "item": {
        "item": "minecraft:iron_shovel"
      }
    },
    {
      "item": {
        "tag": "forge:storage_blocks/source"
      }
    },
    {
      "item": {
        "tag": "forge:storage_blocks/source"
      }
    },
    {
      "item": {
        "tag": "forge:obsidian"
      }
    },
    {
      "item": {
        "tag": "forge:obsidian"
      }
    }
  ],

it looks good to me.

As I'm not so much into Ars Nouveau, can a pedestal"Item" be something else then an item? I'm just wondering because of the nested item -> item/tag.

Do we have more of these? Enchanters Mirror also contains reagent. We probably want to unify them too. Funny that reagent is an array too but not nested.

[PersiflageTheNinth]

As I'm not so much into Ars Nouveau, can a pedestal"Item" be something else then an item? I'm just wondering because of the nested item -> item/tag.

Not that I can tell from the recipe definitions themselves
https://github.com/baileyholl/Ars-Nouveau/blob/1.19.x/src/main/java/com/hollingsworth/arsnouveau/common/crafting/recipes/ImbuementRecipe.java
https://github.com/baileyholl/Ars-Nouveau/blob/1.19.x/src/main/java/com/hollingsworth/arsnouveau/api/enchanting_apparatus/EnchantingApparatusRecipe.java

Do we have more of these? Enchanters Mirror also contains reagent. We probably want to unify them too. Funny that reagent is an array too but not nested.

It's interesting that reagent is an array when it looks like it should just be an Ingredient as well.

GitHub

Ars-Nouveau/ImbuementRecipe.java at 1.19.x · baileyholl/Ars-Nouveau

Contribute to baileyholl/Ars-Nouveau development by creating an account on GitHub.

GitHub

Ars-Nouveau/EnchantingApparatusRecipe.java at 1.19.x · baileyholl/Ars-Nouveau

Contribute to baileyholl/Ars-Nouveau development by creating an account on GitHub.