-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need a 'Cancel' command in the API #156
Comments
In relation to this: When knitting/testing is initiated the host sends a request and the device confirms the request. But when testing is ended, the host sends a quit command with no acknowledgment. I think the device should acknowledge the quit command, and also acknowledge cancelation of the knitting operation. |
I can confirm this behavior in the current 1.0 beta: after canceling a knitting operation, the last line sent to the firmware is repeatedly selected if you keep doing rows with the carriage in KC position. |
I'm concerned that a bug happens when you press
Cancel
in the desktop. The firmware stays in theKnit
state waiting for the last line of the pattern, and never receives it.There probably needs to be a
Cancel
command in the API that resets the state fromKnit
fromInit
.I suggest we simply repurposequitCmd
which resets the state fromTest
toInit
to do the same fromKnit
.Bug possibly introduced in #154.
The text was updated successfully, but these errors were encountered: