Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a 'Cancel' command in the API #156

Open
t0mpr1c3 opened this issue Sep 27, 2023 · 2 comments · May be fixed by #154, #169 or #187
Open

Need a 'Cancel' command in the API #156

t0mpr1c3 opened this issue Sep 27, 2023 · 2 comments · May be fixed by #154, #169 or #187
Assignees
Labels
Milestone

Comments

@t0mpr1c3
Copy link
Contributor

t0mpr1c3 commented Sep 27, 2023

I'm concerned that a bug happens when you press Cancel in the desktop. The firmware stays in the Knit state waiting for the last line of the pattern, and never receives it.

There probably needs to be a Cancel command in the API that resets the state from Knit from Init.

I suggest we simply repurpose quitCmd which resets the state from Test to Init to do the same from Knit.

Bug possibly introduced in #154.

@t0mpr1c3
Copy link
Contributor Author

In relation to this:

When knitting/testing is initiated the host sends a request and the device confirms the request. But when testing is ended, the host sends a quit command with no acknowledgment.

I think the device should acknowledge the quit command, and also acknowledge cancelation of the knitting operation.

t0mpr1c3 added a commit to AllYarnsAreBeautiful/ayab-manual that referenced this issue Apr 15, 2024
@jonathanperret
Copy link
Contributor

I can confirm this behavior in the current 1.0 beta: after canceling a knitting operation, the last line sent to the firmware is repeatedly selected if you keep doing rows with the carriage in KC position.
Not sure this is critical for 1.0 though.

@jonathanperret jonathanperret modified the milestones: 1.0.0, next Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment