Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Mac version in CI/CD Pipeline #2499

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Conversation

SmartManoj
Copy link
Contributor

@SmartManoj SmartManoj commented Jun 18, 2024

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Unit tests[1] [2] [3] are also failing. abiosoft/colima#1023 (comment)

neubig
neubig previously requested changes Jun 18, 2024
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like tests are still failing, and I also think we should try to make them work on the most recent version of Mac if possible

@SmartManoj
Copy link
Contributor Author

SmartManoj commented Jun 18, 2024

Failed for

chmod +x hello.sh
./hello.sh

Output:

-bash: ./hello.sh: Permission denied
[Command -1 finished with exit code 126]

Due to Apple Quarantine

@tobitege
Copy link
Collaborator

tobitege commented Jun 18, 2024

There first permission error/warning is already at the sandbox setup stage:

14:52:44 - opendevin:WARNING: ssh_box.py:356 - Failed to chown workspace directory for opendevin in sandbox: b"chown: changing ownership of '/workspace': Permission denied\n". But this should be fine if the self.sandbox_workspace_dir='/workspace' is mounted by the app docker container.

Edit: potential cause for the actual test to fail is in test itself.

@SmartManoj
Copy link
Contributor Author

Is it constantly failing at the first attempt?

@tobitege
Copy link
Collaborator

Is it constantly failing at the first attempt?

I wish I could answer that, I don't have a way of testing it for Darwin.

@SmartManoj SmartManoj requested a review from neubig June 19, 2024 09:56
@SmartManoj SmartManoj requested a review from li-boxuan June 20, 2024 03:50
@li-boxuan li-boxuan dismissed neubig’s stale review June 20, 2024 05:12

test is passing now

@li-boxuan li-boxuan merged commit 833bb50 into All-Hands-AI:main Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants