[OCTRL-777] Environment declared as failed during the deployment #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5652c05 to
0a41e18
Compare
teo
previously approved these changes
Oct 21, 2024
core/task/manager.go
Outdated
| @@ -326,6 +326,14 @@ func (m *Manager) RefreshClasses(taskClassesRequired []string) (err error) { | |||
| return | |||
| } | |||
|
|
|||
| // prefix will be prepended before name of descriptor | |||
| func logDescriptors(prefix string, logFunc func(format string, args ...interface{}), descriptos Descriptors) { | |||
| for _, desc := range descriptos { | |||
teo
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to trigger "no resources" error on my openstack setup. The problem was that variables were not reset correctly when we were deploying and failing in retry loop. Moreover I moved reporting of UNDEPLOYABLE status after whole retry loop is done. With these changes we are able to successfully retry deployment, if we fail for the first time without involvement of shifter.
Moreover I improved logging a bit, I sent also the error reports to Roberto whether he is fine with the amount of errors reported in this case + the messaging. So please don't merge this yet.