Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifications to auto-detect and decode link-base zero suppression #5569

Merged
merged 4 commits into from
Feb 26, 2021
Merged

Modifications to auto-detect and decode link-base zero suppression #5569

merged 4 commits into from
Feb 26, 2021

Conversation

wiechula
Copy link
Collaborator

No description provided.

@wiechula
Link-based zero suppression in RawReader
49154fb 
o add automatic detection and processing of link-based zero suppression
  in raw reader
o processing helper to decode zero suppressed data from memory and fill
  data using a callback funciton
o minor code cleanup
@wiechula
Change ADC rage to float
277e944
@wiechula
Update header definition
7ca0d41
@wiechula
Modifications to process link-based zero suppression
6302c54
@wiechula
Copy link
Collaborator Author

@shahor02 ,
it seems the failing test is unrelated. Can this PR be merged?

@davidrohr
Copy link
Collaborator

@TimoWilken : The FullCI is failing again with

fatal error: error writing to /tmp/ccC0jXok.s: Cannot allocate memory

Could you check what is the problem? I assume /tmp is mounted as tmpfs and it runs out of memory?

@TimoWilken
Copy link
Contributor

@davidrohr no, nothing special is mounted on /tmp, it's just a regular directory under /, the docker overlay fs. I assume the builder is running out of memory because it's running too much in parallel... reducing JOBS again should probably solve this.

@TimoWilken TimoWilken mentioned this pull request Feb 26, 2021
Merged
@davidrohr
Copy link
Collaborator

@TimoWilken @ktf @ihrivnac : Perhaps we can discuss in a CWG3 meeting how we proceed with the memory. Reducing the number of jobs over and over is no panacea, since it increases the CI time significantly, It would be interesting to see what is the average CPU load on the CI servers, to understand if the CPUs are currently properly used. If not, we should actually install more memory and increase the number of jobs.

@davidrohr davidrohr merged commit ea61077 into AliceO2Group:dev Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiechula @davidrohr @TimoWilken