CMake fixes: #3437
Merged
CMake fixes: #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added FindVGM.cmake to amend the target provided by VGM installation - Fixed test-root-macro.sh.in (removed LD_LIBRARY_PATH from the libraries list))
aphecetche
reviewed
Apr 23, 2020
dependencies/FindVGM.cmake
Outdated
| endif() | ||
|
|
||
| # VGM uses namespace since 4.7 | ||
| message(STATUS ${VGM_VERSION}) |
There was a problem hiding this comment.
is the message intended or a leftover from the testing phase ?
There was a problem hiding this comment.
This was for debugging; I will remove it.
aphecetche
previously approved these changes
Apr 23, 2020
|
@ihrivnac I guess we hit a problem on CC7. Yesterday I wondered why in the first place I've put the LD_LIBRARY_PATH in the test-root-macros but could not remember. I think that is the reason... Might require some investigation to see if / how we can deal properly both with Mac and CC7 but meanwhile I would propose to remove the change in test-root-macro from this PR and just keep the FindVGM one, to get the other (alidist) PR go through. What do you think ? |
|
@aphecetche , thank you. I update the brach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added FindVGM.cmake to amend the target provided by the VGM installation)