-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Use zeromq to put request output tokens back to the api server #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeldaHuang
reviewed
Sep 4, 2024
ZeldaHuang
reviewed
Sep 4, 2024
zhypku
reviewed
Sep 4, 2024
KuilongCui
reviewed
Sep 5, 2024
ZeldaHuang
approved these changes
Sep 10, 2024
KuilongCui
reviewed
Sep 10, 2024
zhypku
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we use ray.queue as the request output queue to store the streaming request output tokens returned by llm engine. However, we found that the cost of ray rpc will become very high when the frequency of remote call is high.
Because the request output queue of a api server could be written by multiple llm engines due to dynamic serving of Llumnix, it means that the frequency of streaming output rpc can be very high. So we decide to use zeromq as the default rpc way of putting streaming request output tokens back to the request output queue.
Besides, rpc(tcp://...) has no more obvious performance interference with step than ipc(ipc://...).