Redesign ACSetFunctors when there are AttrVars #915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to make attrvars play nicer with data migrations. The key change in CSets is to redefine
ACSetFunctor
s, which are used critically in data migrations to compose with ordinary functors representing the migrations themselves, to again always take values inFinSetInt
s andFinDomFunction
s when possible. Previously, theACSetFunctor
of anACSet
containing anyAttrvar
s would take values entirely inVarSet
s, which both confused the difference between actualAttrvar
s and combinatorial data and interfaced badly with theLimit
s API.To make this work I also defined how to compose
FinFunction
s withVarFunction
s on the left.