Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci:force] Migrate to NG15 #8922

Closed
wants to merge 36 commits into from
Closed

[ci:force] Migrate to NG15 #8922

wants to merge 36 commits into from

Conversation

VitoAlbano
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@VitoAlbano VitoAlbano changed the title [CI:FORCE] - testing changes to migrate to NG15 Migrate to NG15 Sep 24, 2023
@VitoAlbano VitoAlbano changed the title Migrate to NG15 [ci:force] Migrate to NG15 Sep 24, 2023
@VitoAlbano VitoAlbano force-pushed the dev-valbano-migration-ng15 branch from 51d70fb to 0d6f08e Compare September 26, 2023 11:14
@VitoAlbano VitoAlbano force-pushed the dev-valbano-migration-ng15 branch 3 times, most recently from 43d0b93 to d7c2dbe Compare September 27, 2023 14:41
@VitoAlbano VitoAlbano force-pushed the dev-valbano-migration-ng15 branch 3 times, most recently from 1656fa7 to 8b2a701 Compare October 2, 2023 22:57
@DenysVuika DenysVuika force-pushed the dev-valbano-migration-ng15 branch from 8b2a701 to 9c46542 Compare October 3, 2023 12:42
@VitoAlbano VitoAlbano force-pushed the dev-valbano-migration-ng15 branch 3 times, most recently from 90f0636 to a67a621 Compare October 10, 2023 21:03
@VitoAlbano VitoAlbano force-pushed the dev-valbano-migration-ng15 branch 6 times, most recently from 7da2c09 to 2faf203 Compare October 24, 2023 18:35
VitoAlbano and others added 26 commits November 1, 2023 00:16
@VitoAlbano
Fixing unit test for core
bfe0c82
@VitoAlbano
Fixed unit test for core
e1fb787
@VitoAlbano
[ci:force] - fixed and skipped process service cloud test
63982d3
@VitoAlbano
[ci:force] - rebased
cdc0638
@VitoAlbano
[ci:force] - fixed lint errors and wrong imports
e550a89
@tomaszhanaj @VitoAlbano
fixed unit tests for content-services v2
5566d98
@tomaszhanaj @VitoAlbano
fixed theme, typography related issues
58be1db
@VitoAlbano
Lint fixing
881b813
@VitoAlbano
[ci:force] - again again
b4d9477
@tomaszhanaj @VitoAlbano
fix for storybook builds
2490427
@VitoAlbano
[ci:force] - do not stop belivin
9d4a390
@tomaszhanaj @VitoAlbano
fixed unit tests for radio-button-widget
356ac46
@VitoAlbano
Fixed import problem and reduced coverage for old process package
4d4c289
@VitoAlbano
[ci:force] excluded test'
6ea02c9
@VitoAlbano
Upgraded affected command
e5ccc50
@VitoAlbano
Fixed some locator and removed chart.js from karma config
af135c5
@VitoAlbano
Fixed import for content-node-share
6042f3b
@VitoAlbano
Fixed migration for storybook
1999a2b
@VitoAlbano
Fixed failing unit test for process after rebase
0bec684
@VitoAlbano
Migration - rebased and fixed unit test after the removal of moment
d8c3d97
@VitoAlbano
Migration - start fixing e2e
61cbd61
@VitoAlbano
Fixed project.json wrongly destroyed after rebase
8a2b4f4
@VitoAlbano
Missed one <sad-face>
fd9f82c
@VitoAlbano
It was missing here as well
84136ee
@VitoAlbano
rebased
87e9396
@VitoAlbano
Dramatic rebase - check
4adcf67
@VitoAlbano VitoAlbano force-pushed the dev-valbano-migration-ng15 branch from 9694e53 to 4adcf67 Compare November 1, 2023 01:55
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@VitoAlbano VitoAlbano closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysVuika DenysVuika DenysVuika left review comments

@wojd0 wojd0 wojd0 approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
enhancement next version ➡️ possible breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VitoAlbano @DenysVuika @wojd0 @tomgny @tomaszhanaj