[AAE-22900] Update ObjectDataTableAdapter to support server and clien… #10418
Conversation
|
|
| @@ -21,7 +21,7 @@ import { ProcessInstanceCloudListViewModel } from '../models/perocess-instance-c | |||
|
|
|||
| export class ProcessListDatatableAdapter extends ObjectDataTableAdapter { | |||
| constructor(data: ProcessInstanceCloudListViewModel[], schema: DataColumn<ProcessListDataColumnCustomData>[]) { | |||
There was a problem hiding this comment.
@DenysVuika @eromano Do we want to provide the ability to set the sortingMode in these extending classes so we can utilize feature flags in the hxp-frontend-apps projects? Not sure if we want a feature flag for this but if we did, we'd need to be able to provide the sort option here.
Based on the information I've received, we don't want pages using these adapters to use client sorting so the constructor parameter would be redundant. Also, we would have to remove the constructor parameter once the feature flag is removed so it seems architecturally redundant.
| @@ -21,7 +21,7 @@ import { TaskInstanceCloudListViewModel } from '../models/task-cloud-view.model' | |||
|
|
|||
| export class TasksListDatatableAdapter extends ObjectDataTableAdapter { | |||
| constructor(data: TaskInstanceCloudListViewModel[], schema: DataColumn<ProcessListDataColumnCustomData>[]) { | |||
There was a problem hiding this comment.
@DenysVuika @eromano Same question for this as the other adapter class comment.
eae327a to
e1aaa99
Compare
e1aaa99 to
4e3e867
Compare
| this._rows = []; | ||
| this._columns = []; | ||
| this._sortingMode = sortingMode?.toString().toLowerCase() === 'server' ? 'server' : 'client'; |
There was a problem hiding this comment.
nit: toString() probably isn't necessary
There was a problem hiding this comment.
Just trying to be super careful incase sortingMode is not provided as a string. You think that's overkill?
There was a problem hiding this comment.
It doesn't really hurt anything, but I would expect all consumers of ObjectDataTableAdapter to be using TypeScript typings, and not need the additional javascript safety checks. I spot checked some files and didn't see anywhere else where typings weren't trusted, but I could have easily missed another file that does.
Personally, I would just account for sortingMode being undefined, but if it is defined assume its a SortingMode.
There was a problem hiding this comment.
Sounds good, makes sense to me. I'll update it.
9361b61 to
d3353f4
Compare
|
Fixes AAE-22900. This adds server sorting for the base
ObjectDataTableAdapterto enable tables in tabs such as "Process Admin" User Tasks, Services Tasks, and Applications List.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
AAE-22900
What is the new behaviour?
Allows for enabling server sorting where it the adapter does not sort the data. The server data is rendered in the order it comes in.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
This a partial fix to the provided story AAE-22900. After this is merged, hxp-frontend-apps will need to be updated by updating the
applications-list-filtered-data-adapteradapter as well.