-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 7.0.0-alpha.5 package-lock.json #10413
Conversation
lib/cli/package-lock.json
Outdated
@@ -9,7 +9,7 @@ | |||
"version": "7.0.0-alpha.5", | |||
"license": "Apache-2.0", | |||
"dependencies": { | |||
"@alfresco/js-api": ">=7.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rollback the change for the cli, here js-api should have older version as we had some issues with that in the past
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should I revert the whole file to the original version? or just this mentioned version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whole file please
package-lock.json
Outdated
@@ -366,229 +366,6 @@ | |||
} | |||
} | |||
}, | |||
"node_modules/@angular-devkit/build-angular/node_modules/@esbuild/android-arm": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why do you have any changes here but I assume it depends on operating system so I would roll those change back too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we roll back the entire file, we would have the same package-lock.json as before, which causes the release job to fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt this part was responsible as the issue was with Original error: Pruned lock file creation failed. The following package was not found in the root lock file: @alfresco/js-api@>=8.0.0-alpha.5
and this version was not changed across this file
Okay I found the real issue - |
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: