Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.0.0-alpha.5 package-lock.json #10413

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

swapnil-verma-gl
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe: Release PR - Pushing missed package-lock.json

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@@ -9,7 +9,7 @@
"version": "7.0.0-alpha.5",
"license": "Apache-2.0",
"dependencies": {
"@alfresco/js-api": ">=7.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rollback the change for the cli, here js-api should have older version as we had some issues with that in the past

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I revert the whole file to the original version? or just this mentioned version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole file please

@@ -366,229 +366,6 @@
}
}
},
"node_modules/@angular-devkit/build-angular/node_modules/@esbuild/android-arm": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why do you have any changes here but I assume it depends on operating system so I would roll those change back too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we roll back the entire file, we would have the same package-lock.json as before, which causes the release job to fail

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this part was responsible as the issue was with Original error: Pruned lock file creation failed. The following package was not found in the root lock file: @alfresco/js-api@>=8.0.0-alpha.5 and this version was not changed across this file

@MichalKinas
Copy link
Contributor

MichalKinas commented Nov 20, 2024

Okay I found the real issue - "@alfresco/js-api": ">=8.0.0-alpha.5", this line in package.json in cli it should point to previous version as otherwise the release will fail since cli is built before js-api

@swapnil-verma-gl swapnil-verma-gl merged commit b4516bc into develop Nov 20, 2024
18 checks passed
@swapnil-verma-gl swapnil-verma-gl deleted the 7.0.0-alpha.5-package-lock branch November 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants