Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-28106 Make the header ( label + style ) optional with a checkbox [Preview/Runtime display] #10408

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

wiktord2000
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

Header is always visible.

What is the new behaviour?

Header can be optional.

Screen.Recording.2024-11-19.at.15.59.02.mov

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

>
<ng-container *ngTemplateOutlet="expandButton; context: { $implicit: element }" />
<span
(click)="onExpanderClicked(element)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move output events to the end?

}

return allowCollapse;
get isGroup(): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most probably is better to rename it into isTypeFieldGroup ?

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@wiktord2000 wiktord2000 merged commit beaf86d into develop Nov 20, 2024
16 of 17 checks passed
@wiktord2000 wiktord2000 deleted the feature/AAE-28106-make-header-optional branch November 20, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants