OPSEXP-2382 Add reusable terraform workflow to manage EKS clusters #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxgomz
reviewed
Nov 27, 2023
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Load environment variables from yml | ||
| uses: Alfresco/alfresco-build-tools/.github/actions/env-load-from-yaml@v5.0.0 |
There was a problem hiding this comment.
I'm not sure about reusing that action. It uses a dodgy syntax inherited from travis.
There was a problem hiding this comment.
not really afraid of it, could be improved, but it needs to keep backward compatibility because it's pretty used
Co-authored-by: Alex Chapellon <alexandre.Chapellon@hyland.com>
4957834 to
7eca5ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Add reusable terraform workflow to manage EKS clusters