Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map blueprint ontology to CL names #983

Conversation

allyhawkins
Copy link
Member

Purpose/implementation Section

Please link to the GitHub issue that this pull request addresses.

Closes #979

What is the goal of this pull request?

Here I am adding a column that maps the ontology ID in BlueprintEncodeData to the CL name found in the cell type ontology.

Briefly describe the general approach you took to achieve this goal.

  • I updated the script that creates the consensus reference table to include a column for the mapped name blueprint_annotation_cl. This also means a huge diff for this file since it includes a new column.
  • Since the reference that we have doesn't have every combination of assignments (due to size constraints), I also map the IDs in the script to combine all tables and add consensus labels. Ultimately, I chose to remove the blueprint_annotation_fine column altogether and just use the blueprint_annotation_cl column.
  • I then updated the readme to reflect this change.

Author checklists

Check all those that apply.
Note that you may find it easier to check off these items after the pull request is actually filed.

Analysis module and review

Reproducibility checklist

  • Code in this pull request has been added to the GitHub Action workflow that runs this module.
  • The dependencies required to run the code in this pull request have been added to the analysis module Dockerfile.
  • If applicable, the dependencies required to run the code in this pull request have been added to the analysis module conda environment.yml file.
  • If applicable, R package dependencies required to run the code in this pull request have been added to the analysis module renv.lock file.

@allyhawkins allyhawkins requested review from jashapiro and removed request for jaclyn-taroni January 13, 2025 21:40
@allyhawkins allyhawkins changed the title Allyhawkins/map blueprint ontology name Map blueprint ontology to CL names Jan 13, 2025
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allyhawkins
Copy link
Member Author

I'm going to cancel the workflow run for this module since the changes I just had to merge in from main aren't relevant.

@allyhawkins allyhawkins merged commit b870a08 into AlexsLemonade:main Jan 14, 2025
2 of 3 checks passed
@allyhawkins allyhawkins deleted the allyhawkins/map-blueprint-ontology-name branch January 14, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use names from cell type ontology (CL) instead of blueprint names in consensus reference
2 participants