Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small hello-clusters notebook cleanups #958

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

sjspielman
Copy link
Member

Noticed a couple bits to clean up/remove from the first hello-clusters notebook, and I updated the HTML. A couple EOL spaces got eaten along the way, so turn off whitespace if you want (though not really necessary here I think).

  • The first removed sentence is no longer accurate
  • The TODO probably doesn't make sense given that that's not what that module actually does! But, I opened Consider using a converted Seurat object in hello-clusters #957 in case we want to update this part in the future (I'm on the fence if we should, but that issue will remind me to get off the fence one way or another!)

@sjspielman sjspielman requested review from jashapiro and removed request for jaclyn-taroni December 20, 2024 14:38
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjspielman sjspielman merged commit 22315fc into AlexsLemonade:main Dec 20, 2024
3 checks passed
@sjspielman sjspielman deleted the sjspielman/hello-patch branch December 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants