Initiate seurat-conversion
#946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjspielman
approved these changes
Dec 16, 2024
Comment on lines
+55
to
+57
| # Update this step as needed to download the desired data | ||
| - name: Download test data | ||
| run: ./download-data.py --test-data --format SCE |
There was a problem hiding this comment.
Will we want any filtered data to show with sce_to_seurat()? Certainly don't have to decide or change anything now, just a thought as this gets developed.
Comment on lines
+3
to
+4
| RestoreWorkspace: No | ||
| SaveWorkspace: No |
There was a problem hiding this comment.
..or perhaps not to see it, as it were!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
This PR sets up the
seurat-conversionmodulePlease link to the GitHub issue that this pull request addresses.
#945
What is the goal of this pull request?
Just the first step in #945
Briefly describe the general approach you took to achieve this goal.
I ran the
create-analysis-module.pyscript with--use-renvenabled. I then made small edits to the Dockerfile and README in anticipation of future changes. The README is still quite incomplete, but will be expanded as code is added.If known, do you anticipate filing additional pull requests to complete this analysis module?
Yup!
Provide directions for reviewers
Does everything look correct?
What are the software and computational requirements needed to be able to run the code in this PR?
Nothing but R, I think!
Are there particularly areas you'd like reviewers to have a close look at?
Not really
Is there anything that you want to discuss further?
Author checklists
Analysis module and review
README.mdhas been updated to reflect code changes in this pull request.Reproducibility checklist
Dockerfile.environment.ymlfile.renv.lockfile.