Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module for metacells analysis #608

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

jashapiro
Copy link
Member

@jashapiro jashapiro commented Jul 12, 2024

Purpose/implementation Section

Please link to the GitHub issue that this pull request addresses.

Closes #598

What is the goal of this pull request?

The goal for this PR is mostly to establish the initial infrastructure for analysis, including the environment for future analysis.

Briefly describe the general approach you took to achieve this goal.

The general path that ended up working for determining requirements was to start with a pip install of SEACells, then move packages from pip to conda control one at a time. The packages that remain in pip install fine there, but in some cases did not have conda packages for all systems

If known, do you anticipate filing additional pull requests to complete this analysis module?

Yes, many!

Provide directions for reviewers

What are the software and computational requirements needed to be able to run the code in this PR?

Everything should be available through conda and pip at this stage

Are there particularly areas you'd like reviewers to have a close look at?

If you would like to test that the packages build and install locally, that would be fine, but I also expect to catch any such errors through future testing, and I expect some small environment changes before much code is added.

Is there anything that you want to discuss further?

Author checklists

Analysis module and review

Reproducibility checklist

  • Code in this pull request has been added to the GitHub Action workflow that runs this module.
  • The dependencies required to run the code in this pull request have been added to the analysis module Dockerfile.
  • If applicable, the dependencies required to run the code in this pull request have been added to the analysis module conda environment.yml file.
  • If applicable, R package dependencies required to run the code in this pull request have been added to the analysis module renv.lock file.

@jashapiro jashapiro requested a review from allyhawkins as a code owner July 12, 2024 20:33
Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't test the environment build, but as you said in your PR some of those things will come out as you get started on things. Onward to getting Metacells 🚀

@jashapiro jashapiro merged commit 2ad5bf3 into AlexsLemonade:main Jul 15, 2024
2 checks passed
@jashapiro jashapiro deleted the jashapiro/598-metacell-start branch July 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metacell analysis
2 participants