This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rearrange table order - add S2 title
AppVeyor build 1.0.121 for commit 77e9f00 is now complete. Found 24 potential spelling error(s). Preview:content/03.methods.md:5:CBTNcontent/03.methods.md:7:CBTN content/03.methods.md:9:CBTN content/03.methods.md:9:CBTN content/03.methods.md:10:CBTN content/03.methods.md:11:CBTN content/03.methods.md:13:CBTN content/03.methods.md:39:CBTN content/03.methods.md:58:CBTN content/03.methods.md:283:CBTN content/03.methods.md:285:CBTN content/03.methods.md:300:CBTN content/03.methods.md:336:Occipital content/03.methods.md:337:Brai... |
add line about `pathology_diagnosis` and `pathology_free_text_diagnosis` in subtyping section
AppVeyor build 1.0.122 for commit 320e253 is now complete. Found 24 potential spelling error(s). Preview:content/03.methods.md:5:CBTNcontent/03.methods.md:7:CBTN content/03.methods.md:9:CBTN content/03.methods.md:9:CBTN content/03.methods.md:10:CBTN content/03.methods.md:11:CBTN content/03.methods.md:13:CBTN content/03.methods.md:39:CBTN content/03.methods.md:58:CBTN content/03.methods.md:283:CBTN content/03.methods.md:285:CBTN content/03.methods.md:300:CBTN content/03.methods.md:336:Occipital content/03.methods.md:337:Brai... |
add genes/brain region terms to dictionary
AppVeyor build 1.0.123 Found 0 potential spelling error(s). Preview:... |
jaclyn-taroni
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I had one suggestion, but I am not attached to that idea.
add suggestion from review Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
AppVeyor build 1.0.124 for commit cf9b226 is now complete. Found 0 potential spelling error(s). Preview:... |
fix two typos
AppVeyor build 1.0.125 for commit d61ccb5 is now complete. Found 0 potential spelling error(s). Preview:... |
This was referenced Sep 28, 2020
Closed
github-actions bot
pushed a commit
that referenced
this pull request
Sep 28, 2020
[ci skip] This build is based on 00d0597. This commit was created by the following CI build and job: https://github.com/AlexsLemonade/OpenPBTA-manuscript/commit/00d059701f795fbfc8e7335d8c525641669103c9/checks https://github.com/AlexsLemonade/OpenPBTA-manuscript/runs/277150432
github-actions bot
pushed a commit
that referenced
this pull request
Sep 28, 2020
[ci skip] This build is based on 00d0597. This commit was created by the following CI build and job: https://github.com/AlexsLemonade/OpenPBTA-manuscript/commit/00d059701f795fbfc8e7335d8c525641669103c9/checks https://github.com/AlexsLemonade/OpenPBTA-manuscript/runs/277150432
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Briefly describe your changes here.
pathology_free_text_diagnosis
integrated_diagnosis
cohort_participant_id
topbta-histologies.tsv
metadata tableglioma_brain_region
toCNS_region
and update descriptionIssue
What GitHub issue does your pull request address?
#123
#113
#106
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
NA
Is there anything that you want to discuss further?
No
Is the pull request ready for review?
Yes
Pull review checklist
Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.
Spellcheck Step
The dictionary used for spellchecking can be updated.
Edit the file in
build/assets/custom-dictionary.txt
by adding new entries to the end.You do not need to change anything else.
However, if you want to update the first line to have an accurate count of words and you want to remove non-unique ones, run the following command from within
build/assets
on your favorite OS X or Linux machine: