Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Hgg subtype update: Adding tp53 status #943

Merged
merged 9 commits into from
Feb 18, 2021

Conversation

kgaonkar6
Copy link
Collaborator

@kgaonkar6 kgaonkar6 commented Feb 16, 2021

⚠️ merge after #942 is in master

Purpose/implementation Section

What scientific question is your analysis addressing?

Adding TP53 status along with evidence columns(tp53_XYZ from classifier,SNV and CNV calls to HGG samples.

What was your approach?

I am using tp53_nf1_score/results/tp53_altered_status.tsv to add the tp53_altered status to the subtypes already annotated to the sample_id

What GitHub issue does your pull request address?

#807

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@kgaonkar6 kgaonkar6 changed the title Hgg tp53 status Hgg subtype update: Adding tp53 status Feb 16, 2021
Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we want to capture any TP53-altered samples in the subtyping, rather than just loss. For HGG_molecular_subtype.tsv, will you also add TP53 activated?

Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
@kgaonkar6
Copy link
Collaborator Author

I think that we want to capture any TP53-altered samples in the subtyping, rather than just loss. For HGG_molecular_subtype.tsv, will you also add TP53 activated?
will do!

@kgaonkar6 kgaonkar6 added ready for review Used to label pull requests that are ready for review and removed don't merge labels Feb 18, 2021
Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

@jharenza jharenza merged commit 8338829 into AlexsLemonade:master Feb 18, 2021
@jharenza jharenza mentioned this pull request Feb 23, 2021
5 tasks
@kgaonkar6 kgaonkar6 deleted the HGG-TP53-status branch May 13, 2021 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready for review Used to label pull requests that are ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants