This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
Using mapping histology groups for plotting -- Part 2 implemention (PR 2 of 4) #911
Merged
jaclyn-taroni
merged 55 commits into
AlexsLemonade:master
from
cansavvy:cansavvy/update-histology-colors-1
Jan 20, 2021
Merged
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
e708bb1
Push the basic notebook so far
cansavvy d2e0fc7
Make color palette smaller and move set.seed()
cansavvy f571738
Polishing polishing polishing
cansavvy 15a3651
One more formatting edit
cansavvy a02c616
Add to CI testing
cansavvy bc4935a
Merge branch 'master' into cansavvy/mapping-table
cansavvy 5e00fe2
Fix formatting in CI test file whoops
cansavvy 4580439
Merge remote-tracking branch 'cansavvy/cansavvy/mapping-table' into c…
cansavvy 571e8c7
Update chromosomal-instability and figures bits
cansavvy 959b683
Incorporate part of jashapiro review
cansavvy a173f91
Push a few other changes from jashapiro review
cansavvy a3c165b
re-run notebook
cansavvy 81b3004
Update documentation
cansavvy f339b42
Merge branch 'master' into cansavvy/mapping-table
cansavvy 566a7c6
Add back the `Normal` labels
cansavvy 3ceaaf3
Merge remote-tracking branch 'cansavvy/cansavvy/mapping-table' into c…
cansavvy 55819b3
Change summary_group -> display_group
cansavvy 4e4a7f0
Switch to jharenza recomendations (also do capitalization thing)
cansavvy 465477e
Get rid of small_groups_cutoff remnant
cansavvy 8896f0a
Merge branch 'master' into cansavvy/mapping-table
cansavvy 709e623
Incorporate jharenza review -- make Other and Benign gray
cansavvy a0603b7
Merge remote-tracking branch 'cansavvy/cansavvy/mapping-table' into c…
cansavvy c34f8d4
Merge branch 'cansavvy/mapping-table' into cansavvy/mapping-README
cansavvy 6ac8a8e
Some tidyverse rearranging because hex_codes weren't actually saving …
cansavvy 35a0700
Okay had my hex_code list/names backwards now we're good
cansavvy 098fece
Merge branch 'cansavvy/mapping-table' into cansavvy/mapping-README
cansavvy 4cdd4dd
Re-run chromosomal instability with the new colors
cansavvy eadf795
A couple more things in figures/README were out of date
cansavvy 1110c69
Add a re-run of figures/mapping-histology-labels.Rmd to generate_figu…
cansavvy 9a77701
Update cnv-chrom-plot to use new histology colors
cansavvy 975fbf4
Change to mutational-signatures to new histology mappings -- re-run
cansavvy a479b34
Don't do tolower on all those variables!
cansavvy 5220245
Merge branch 'cansavvy/mapping-table' into cansavvy/mapping-README
cansavvy d8a599a
Make normal NA
cansavvy 3b238ec
Merge remote-tracking branch 'origin/master' into cansavvy/mapping-RE…
cansavvy 69d7f79
Re-run chromsomal-instability heatmaps
cansavvy 5cdb6af
Merge remote-tracking branch 'origin/master' into cansavvy/update-his…
cansavvy f6136ce
Re-run cn-status-heatmap.Rmd
cansavvy 86df39f
Re-run known mutational signatures nb
cansavvy 1317989
Add display_order column and instructions
cansavvy 54172ad
Implement `display_order`
cansavvy 48d0761
Also push reran notebook for cn_breaks heatmap
cansavvy f2764b1
Incorporate jashapiro streamlining suggestion
cansavvy aec0573
Missed a `dplyr::`
cansavvy fa67d60
Change to using select and as.factor() and re-run
cansavvy abff3ff
Drop as.factor and re-run
cansavvy 05969e9
Merge branch 'cansavvy/mapping-README' into cansavvy/update-histology…
cansavvy 451e5e2
Update cnv_status_heatmap with display_order
cansavvy 8b99efb
Re-run known signatures
cansavvy e264996
Merge branch 'master' into cansavvy/update-histology-colors-1
cansavvy a796d4b
Merge remote-tracking branch 'origin/master' into cansavvy/update-his…
cansavvy 490ad12
Add jashapiro function change to get rid of spaces
cansavvy 783390b
Re-run mutational signatures so plot names are updated
cansavvy 094dcc6
Push updated notebook html too I guess
cansavvy 0bb8aff
Merge branch 'master' into cansavvy/update-histology-colors-1
jaclyn-taroni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little worried about separate
unique()
calls preserving order... I think it should work fine, but it seems somehow dangerous to me. So I present an alternative below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I like this better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out the name argument for
pull
is not in our version of dplyr for our docker image, so I can't use the last part, but I will add a distinct to this part but in my subsequent PR of this series.