This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapping high level histology color labels -- Part 1 #899
Mapping high level histology color labels -- Part 1 #899
Changes from 8 commits
e708bb1
d2e0fc7
f571738
15a3651
a02c616
bc4935a
5e00fe2
4580439
959b683
a173f91
a3c165b
81b3004
f339b42
566a7c6
3ceaaf3
4e4a7f0
465477e
8896f0a
709e623
a0603b7
6ac8a8e
35a0700
a479b34
9e79a70
242c21e
449cb0f
ec68189
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would here again print out the full table to make it easier to evaluate what has happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing when making the colors is that I feel like we should treat "Other" as special, and always assign it a standard color, something neutral & grey like
#A0A0A0
(though I am not sure how that fits with colorblind-friendly schemes).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, we could drop this "Other" group from the large summary figures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We consider treating "Benign" as the grey group @jashapiro and @cansavvy - because it's more like a control and we would be less interested (maybe) in those genomics.
Large diffs are not rendered by default.