Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

v17-Release #764

Merged
merged 16 commits into from
Sep 15, 2020
Merged

v17-Release #764

merged 16 commits into from
Sep 15, 2020

Conversation

baileyckelly
Copy link
Collaborator

@baileyckelly baileyckelly commented Sep 11, 2020

Purpose/implementation Section

v17-Release to update the pbta-histologies file
closes #732

  1. updated files description
  2. updated release notes
  3. Updated download script to point to v16/v17

What scientific question is your analysis addressing?

n/a

What was your approach?

n/a

What GitHub issue does your pull request address?

#637 Updated Histologies File
#631 LGAT subtyping
#623 EWS subtyping
#742 consensus of two classifiers for medulloblastoma

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

compare v16 & v17 histologies file

Which areas should receive a particularly close look?

all values were pulled fresh from the source databases so should be reviewed for changes vs v16

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

n/a

Results

n/a

What types of results are included (e.g., table, figure)?

n/a

What is your summary of the results?

n/a

Reproducibility Checklist

n/a

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

n/a

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Data Release Checklist

  • Is the table in doc/data-file-descriptions.md up to date?
  • Is doc/data-format.md up to date?
  • Is doc/release-notes.md up to date?
  • Is download-data.sh up to date?

1. updated files description
2. updated release notes
3. Updated download script to point to v16/v17
@jharenza jharenza added the work in progress Used to label (non-draft) pull requests that are not yet ready for review label Sep 11, 2020
Added clinical columns that changed
added notes for integrated dx
@baileyckelly
Copy link
Collaborator Author

Made suggested changes to
Uploaded new md5.txt, release-notes.md, and pbta-histologies.tsv to S3.

@jaclyn-taroni
Copy link
Member

@baileyckelly Apologies, we forgot about the update to the PBTA TMB file (pbta-snv-consensus-mutation-tmb-coding.tsv) post bug fix, etc. (#727 and #728). @cansavvy posted the updated file here: #732 (comment). This came to my attention when I was working on #765.

@jharenza
Copy link
Collaborator

@baileyckelly Apologies, we forgot about the update to the PBTA TMB file (pbta-snv-consensus-mutation-tmb-coding.tsv) post bug fix, etc. (#727 and #728). @cansavvy posted the updated file here: #732 (comment). This came to my attention when I was working on #765.

I will take care of this now.

add PBTA TMB file `pbta-snv-consensus-mutation-tmb-coding.tsv` to release notes
@jharenza jharenza added ready for review Used to label pull requests that are ready for review and removed work in progress Used to label (non-draft) pull requests that are not yet ready for review labels Sep 11, 2020
@jharenza
Copy link
Collaborator

jharenza commented Sep 11, 2020

@jaclyn-taroni the download works and this is now ready for review. I semi-reviewed, but was also helping @baileyckelly, did some QC on the file, so requesting re-review!

@jaclyn-taroni
Copy link
Member

The HGG molecular subtyping step is broken due to a v17 change to the histologies file. I commented that out in 2335db8. I am hoping that by getting past that step we can find anything else we need to resolve, fix or track it, merge #765, and then we'll get this in!

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready for review Used to label pull requests that are ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Planned Data Release: V17
5 participants