Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Chr instability: PR 2 of 3: Create binned count heatmaps #524

Merged
merged 22 commits into from
Feb 11, 2020

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented Feb 6, 2020

Purpose/implementation Section

The next 3 PRs are the redone versions of the material that was included in #492.

This first PR includes the second of three notebooks which contain the material that was originally all in the previous 01 notebook.

What scientific question is your analysis addressing?

The items on #487 pertaining to this PR:

  • The excluded regions BED file needs to be used
    - For the denominator for calculating densities
    - For marking NA on heatmap

What was your approach?

This takes the binned counts from the 01-localization notebook and makes the heatmaps for them.

What GitHub issue does your pull request address?

#487

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

  • Are you able to figure out why the colors for histologies are not staying consistent even though I actually specify them specifically?
  • Should I make the color function key adjusted for each dataset? Or do we like the consistency across the heatmaps?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

The plots will be in the next two notebooks which I will add in the next two PRs.

What is your summary of the results?

Here's the rendered html: https://cansavvy.github.io/openpbta-notebook-concept/chromosomal-instability/02a-plot-chr-instability-heatmaps.nb.html

Reproducibility Checklist

These items were done previously.

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date (Note it includes documentation for the upcoming notebooks as well.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

…dea why cnv heatmap wasn't being updated????
@cansavvy
Copy link
Collaborator Author

@jashapiro , do you have an outstanding concerns regarding this PR? Were your changes implemented as you expected?

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the heatmap is mostly what we want, this looks good to go in. Just the request to update docs of breaks_heatmap() to reflect some of the constraints on structure of the color list and histology data frame.

@jaclyn-taroni jaclyn-taroni merged commit 4819bec into AlexsLemonade:master Feb 11, 2020
@cansavvy cansavvy deleted the reog-chr-insta-2 branch February 28, 2020 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants