This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
Chr instability: PR 2 of 3: Create binned count heatmaps #524
Merged
jaclyn-taroni
merged 22 commits into
AlexsLemonade:master
from
cansavvy:reog-chr-insta-2
Feb 11, 2020
Merged
Chr instability: PR 2 of 3: Create binned count heatmaps #524
jaclyn-taroni
merged 22 commits into
AlexsLemonade:master
from
cansavvy:reog-chr-insta-2
Feb 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashapiro
reviewed
Feb 6, 2020
analyses/chromosomal-instability/01-localization-of-breakpoints.Rmd
Outdated
Show resolved
Hide resolved
…dea why cnv heatmap wasn't being updated????
jashapiro
reviewed
Feb 7, 2020
analyses/chromosomal-instability/02a-plot-chr-instability-heatmaps.Rmd
Outdated
Show resolved
Hide resolved
jashapiro
reviewed
Feb 7, 2020
analyses/chromosomal-instability/02a-plot-chr-instability-heatmaps.Rmd
Outdated
Show resolved
Hide resolved
jashapiro
reviewed
Feb 7, 2020
analyses/chromosomal-instability/02a-plot-chr-instability-heatmaps.Rmd
Outdated
Show resolved
Hide resolved
@jashapiro , do you have an outstanding concerns regarding this PR? Were your changes implemented as you expected? |
jashapiro
reviewed
Feb 10, 2020
jashapiro
reviewed
Feb 10, 2020
jashapiro
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the heatmap is mostly what we want, this looks good to go in. Just the request to update docs of breaks_heatmap()
to reflect some of the constraints on structure of the color list and histology data frame.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
The next 3 PRs are the redone versions of the material that was included in #492.
This first PR includes the second of three notebooks which contain the material that was originally all in the previous 01 notebook.
What scientific question is your analysis addressing?
The items on #487 pertaining to this PR:
- For the denominator for calculating densities
- For marking NA on heatmap
What was your approach?
This takes the binned counts from the 01-localization notebook and makes the heatmaps for them.
What GitHub issue does your pull request address?
#487
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
The plots will be in the next two notebooks which I will add in the next two PRs.
What is your summary of the results?
Here's the rendered html: https://cansavvy.github.io/openpbta-notebook-concept/chromosomal-instability/02a-plot-chr-instability-heatmaps.nb.html
Reproducibility Checklist
These items were done previously.
Documentation Checklist
README
and it is up to date (Note it includes documentation for the upcoming notebooks as well.analyses/README.md
and the entry is up to date.