This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
V22 CI updates for consensus_seg_with_status.tsv (2/N release)
#1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 19, 2022 14:57
* WIP: update shell * Revert RUN_LOCAL change * Fix missing curly bracket * Account for TMB files Don't skip header! * Add mkdir to cover case when subsetting is skipped first
consensus_seg_with_status.tsvconsensus_seg_with_status.tsv (2/N release)
Co-Authored-By: Miguel Brown <miguel.a.brown@gmail.com>
Co-Authored-By: Miguel Brown <miguel.a.brown@gmail.com>
|
@jaclyn-taroni and @migbro, we are in business! |
|
@jharenza Great to hear! I will kill that ec2 instance then |
jaclyn-taroni
approved these changes
Jun 7, 2022
| @@ -31,6 +31,10 @@ cd "$script_directory" || exit | |||
| # generated via these scripts | |||
| FULL_DIRECTORY=../../data/$RELEASE | |||
| SUBSET_DIRECTORY=../../data/testing/$RELEASE | |||
| # If run subsetting only, we need to make this directory | |||
| if [ ! -d ${SUBSET_DIRECTORY} ]; then | |||
| mkdir -p ${SUBSET_DIRECTORY} | |||
There was a problem hiding this comment.
It doesn't matter, but I don't think you need this logic if you use -p with mkdir.
|
This module is upstream of CI and doesn't get tested. Merging without it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
Add
consensus_seg_with_status.tsvto subsettingWhat was your approach?
What GitHub issue does your pull request address?
#1426
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
READMEand it is up to date.analyses/README.mdand the entry is up to date.