Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

V22 run MB subtyping (3/N) #1435

Merged
merged 42 commits into from
Jun 6, 2022
Merged

V22 run MB subtyping (3/N) #1435

merged 42 commits into from
Jun 6, 2022

Conversation

jharenza
Copy link
Collaborator

Purpose/implementation Section

What scientific question is your analysis addressing?

Run MB subtyping

What was your approach?

What GitHub issue does your pull request address?

#1207 #1426

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

yes

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

No change in subtypes, only clinical data

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza changed the base branch from master to v22-chr-instab May 26, 2022 03:27
@jaclyn-taroni
Copy link
Member

Are all the changes in analyses/molecular-subtyping-MB/input/subset-mb-clinical.tsv expected?

@jharenza
Copy link
Collaborator Author

Are all the changes in analyses/molecular-subtyping-MB/input/subset-mb-clinical.tsv expected?

It looks like these are because of column order changes. I didn't think that would have a major effect, but let me go back and match the order of the new base to previous so it is easier to detect changes. Also, parental_aliquot_id will no longer exist in base since it was removed from our database.

@jharenza
Copy link
Collaborator Author

@jaclyn-taroni looks a bit cleaner in 0e6f745. Expected changes due to base file.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jharenza jharenza merged commit d51f501 into v22-chr-instab Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants