-
Notifications
You must be signed in to change notification settings - Fork 83
Update snv-callers to be able to be run from places besides the root of repo #1420
Update snv-callers to be able to be run from places besides the root of repo #1420
Conversation
Okay, two updates since filing:
|
# The sqlite database made from the callers will be called: | ||
dbfile=scratch/snv_db.sqlite | ||
dbfile=../../scratch/snv_db.sqlite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we made the S2 figures, this path got written in during review. To my knowledge figures are the only thing that needs to use these databases after this module. So, we can either revert back the figures path, or save the databases there in the first place.
scratch_dir <- file.path(root_dir, "scratch", "snv-callers-panels") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I split the difference (kind of) in 054616b. It's a good call for modules to have their own directories in scratch/
, rather than just hoping their are no file name collisions in scratch/
! But I also think snv-callers
is more appropriate than snv-callers-panels
.
# The sqlite database made from the callers will be called: | ||
dbfile=scratch/tcga_snv_db.sqlite | ||
dbfile=../../scratch/tcga_snv_db.sqlite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as before for the scratch path.
This reverts commit 5520021.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closes #1406.
The shell scripts in
snv-callers
made an assumption that you'd run it from the root of the repository. That will be a problem when the script for generating analysis files (run fromscripts/
!!) is including in an upcoming PR. This PR introduces the following changes to thesnv-callers
module:analyses/snv-callers/scripts/02-merge_callers.R
andanalyses/snv-callers/scripts/03-calculate_tmb.R
. We still need to make use ofrprojroot
, however, to make sure we're able tosource()
appropriately.