This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
update figures README #1172
Merged
update figures README #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add figure theme - add statistics info
There was a problem hiding this comment.
Thanks for this @jharenza - I had a few comments in the interest of clarity and a question about what you're trying to convey with the table of options.
Based on your answer to that question, I expect I'll have some suggestions about how to frame the text such that we accomplish your goal.
Comment on lines
+204
to
+209
| | | 2 groups | 3+ groups | | ||
| |--------------------------------------------|------------------------------------------------------|-----------------------------------------------------------------------| | ||
| | Default test (method) | Wilcoxon | Kruskal-wallis | | ||
| | Allowed methods | "wilcox.test" (non-parametric) "t.test" (parametric) | "kruskal.test" (non-parametric) "anova" (parametric) | | ||
| | Default multiple testing (p.adjust.method) | NA | yes, but not bonferroni | | ||
| | Allowed p.adjust.method | NA | "holm", "hochberg", "hommel", "bonferroni", "BH", "BY", "fdr", "none" | |
There was a problem hiding this comment.
Is the point of this table to convey an opinion about what to do or more of an FYI type of thing?
There was a problem hiding this comment.
more of an FYI so people don't have to dig into what the options are because the help is not helpful
Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
add `r` Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
add `r` Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
add r and bash to quoted text
Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
jaclyn-taroni
approved these changes
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
Update Figures README for cohesive theme for manuscript
What was your approach?
cancer groupWhat GitHub issue does your pull request address?
#1158
#761
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Generally the whole addition :)
Is there anything that you want to discuss further?
Is there anything else we want to include?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
yes
Documentation Checklist
READMEand it is up to date.analyses/README.mdand the entry is up to date.