Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

#1144 part3 update telomerase activities figure #1168

Merged
merged 5 commits into from
Sep 1, 2021

Conversation

kgaonkar6
Copy link
Collaborator

@kgaonkar6 kgaonkar6 commented Aug 31, 2021

Purpose/implementation Section

What scientific question is your analysis addressing?

Update Telomerase activity with cancer_groups.

What was your approach?

Updated code to only plot cancer_groups for main figure

What GitHub issue does your pull request address?

#1144

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Do we want the Medulloblastoma or other molecular subtype plots in this figure?

Is there anything that you want to discuss further?

NA

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

yes

Results

What types of results are included (e.g., table, figure)?

figure

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kgaonkar6 - I just see an NA group at the end of the boxplot, so if you can remove that, I will pre-approve and @jaclyn-taroni can merge afterwards :)

@jaclyn-taroni
Copy link
Member

I'm going to label this with don't merge until the NA gets removed.

@kgaonkar6
Copy link
Collaborator Author

@jaclyn-taroni I've removed the NA now. Thanks for the review @jharenza @jaclyn-taroni !

@jaclyn-taroni jaclyn-taroni merged commit d2dfdde into AlexsLemonade:master Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants