-
Notifications
You must be signed in to change notification settings - Fork 83
#1144 part1: Interaction plot updated to cancer_groups #1159
#1144 part1: Interaction plot updated to cancer_groups #1159
Conversation
…/kgaonkar6/OpenPBTA-analysis into interaction-plot-hex-code-update
It looks like there are a lot of
The rest being |
…/kgaonkar6/OpenPBTA-analysis into interaction-plot-hex-code-update
Thanks for the review @jharenza ! In addition to including your suggestion above, I've also used the cancer_group_hex_code now so that the colors are consistent as you suggested in another PR ( that also was a to-do in the original script ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thank you!
Purpose/implementation Section
What scientific question is your analysis addressing?
The barplot visualizing the distribution of the disease groups needs to be updated to cancer_group.
What was your approach?
The only update is changing
OpenPBTA-analysis/analyses/interaction-plots/scripts/02-process_mutations.R
Line 336 in 1d1ace9
to
What GitHub issue does your pull request address?
#1144
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
We only want to update the barplot to cancer group, but the original cooccurrence analysis would remain at broad_histology level.
The update will affect the following files, all other file changed in the PR it seems are from small decimal value changes.
results/gene_disease_top50.tsv
plots/gene_disease_top50.png
In addition to updating disease group as
cancer_group
I'm also removing cancer_group == NA while plotting barplot because otherwise a NA factor with no color is added. These are samples with harmonized_diagnosis == Benign tumor, Dysplasia/Gliosis which will not have a cancer_group.Like:
NA
while assigningcancer_groups
.Is there anything that you want to discuss further?
NA
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
figures and tables
What is your summary of the results?
Updated diagnosis groups

Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.