This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
oncoprint update PR 2/n replace display group with cancer_group #1147
Merged
jharenza
merged 45 commits into
AlexsLemonade:master
from
kgaonkar6:onco-updated-display-group
Aug 26, 2021
Merged
oncoprint update PR 2/n replace display group with cancer_group #1147
jharenza
merged 45 commits into
AlexsLemonade:master
from
kgaonkar6:onco-updated-display-group
Aug 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update gene lists (add a few C19MC key genes for ETMRs to embryonal, add ALK and ROS to hgat, move ependymal genes to other list, remove ependymal list) - move ependymal tumor to CNS other oncoprint since there were so few genes in the plot - to enable better panel set up for a main figure - convert relative paths to point to the data directory - updated README
- remove 7316 IDs (TSB) - remove row bar
…BTA-analysis into onco-updated-display-group
…BTA-analysis into onco-updated-display-group
…BTA-analysis into onco-updated-display-group
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
…BTA-analysis into onco-updated-display-group
jharenza
approved these changes
Aug 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better! We probably want to exclude from the legend cancer groups with samples not shown, but can tackle that in a separate PR. Those are most likely samples which are not mutated.
…BTA-analysis into onco-updated-display-group
…kar6/OpenPBTA-analysis into onco-updated-display-group
jharenza
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you do a rerun with this palette which was specified in figures? Then we can get this one through.
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 merge #1142 and #1143 before this PR
Purpose/implementation Section
What scientific question is your analysis addressing?
Rerunning oncoprint with cancer_group color codes
What was your approach?
I've created this branch from #1143 and pulled the latest branch from #1142 and updated code to use cancer_group instead of display_group along with the required hex_codes for cancer_group.
What GitHub issue does your pull request address?
#1141
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Do the plots look as expected?
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
figure
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.