Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

oncoprint update PR 2/n replace display group with cancer_group #1147

Merged
merged 45 commits into from
Aug 26, 2021

Conversation

kgaonkar6
Copy link
Collaborator

@kgaonkar6 kgaonkar6 commented Aug 18, 2021

🚨 merge #1142 and #1143 before this PR

Purpose/implementation Section

What scientific question is your analysis addressing?

Rerunning oncoprint with cancer_group color codes

What was your approach?

I've created this branch from #1143 and pulled the latest branch from #1142 and updated code to use cancer_group instead of display_group along with the required hex_codes for cancer_group.

What GitHub issue does your pull request address?

#1141

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Do the plots look as expected?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

figure

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Ubuntu and others added 26 commits August 17, 2021 21:21
- update gene lists (add a few C19MC key genes for ETMRs to embryonal, add ALK and ROS to hgat, move ependymal genes to other list, remove ependymal list)
- move ependymal tumor to CNS other oncoprint since there were so few genes in the plot - to enable better panel set up for a main figure
- convert relative paths to point to the data directory
- updated README
- remove 7316 IDs (TSB)
- remove row bar
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
@kgaonkar6 kgaonkar6 requested a review from jharenza August 18, 2021 20:57
@jharenza jharenza added blocked Blocked by factors external to this project don't merge labels Aug 19, 2021
@kgaonkar6
Copy link
Collaborator Author

Just wanted to comment here that I've updated colors as per latest commit bbfcea9 in #1142 and using v21 histologies file

Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better! We probably want to exclude from the legend cancer groups with samples not shown, but can tackle that in a separate PR. Those are most likely samples which are not mutated.

@jharenza jharenza removed the blocked Blocked by factors external to this project label Aug 25, 2021
Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do a rerun with this palette which was specified in figures? Then we can get this one through.

kgaonkar6 and others added 2 commits August 26, 2021 17:22
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
@kgaonkar6 kgaonkar6 requested a review from jharenza August 26, 2021 13:00
@jharenza jharenza merged commit f3cbc4b into AlexsLemonade:master Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants