This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
Update focal-cn-preparation to use consensus SEG file in data download #1130
Closed
jaclyn-taroni
wants to merge
17
commits into
AlexsLemonade:master
from
jaclyn-taroni:jaclyn-taroni/fix-focal-long-running
Closed
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0fe0890
Merge remote-tracking branch 'upstream/master'
jaclyn-taroni 7c0997c
Merge remote-tracking branch 'upstream/master'
jaclyn-taroni 8727fac
Merge remote-tracking branch 'upstream/master'
jaclyn-taroni e7f1d0a
Merge remote-tracking branch 'upstream/master'
jaclyn-taroni a199d3c
Merge remote-tracking branch 'upstream/master'
jaclyn-taroni 8431b1e
Merge remote-tracking branch 'upstream/master'
jaclyn-taroni c29d225
Merge branch 'AlexsLemonade:master' into master
jaclyn-taroni 5292b8e
Merge branch 'AlexsLemonade:master' into master
jaclyn-taroni 6175d61
Merge branch 'AlexsLemonade:master' into master
jaclyn-taroni 43830e8
Merge remote-tracking branch 'upstream/master'
jaclyn-taroni ed4bb16
Merge branch 'AlexsLemonade:master' into master
jaclyn-taroni 0a5093a
Merge remote-tracking branch 'upstream/master'
jaclyn-taroni d9e5645
Merge remote-tracking branch 'upstream/master'
jaclyn-taroni c1a5c8c
Try using the consensus seg in the download file
jaclyn-taroni e12a34e
Comment out other steps
jaclyn-taroni 1ddda21
Merge branch 'master' into jaclyn-taroni/fix-focal-long-running
jaclyn-taroni 9f1160a
Revert "Comment out other steps"
jaclyn-taroni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jharenza and @kgaonkar6 - is there any reason (that you are aware of) that prohibits me from making this change at this point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think so - the latest file is in the download.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to wait until all the v20 CNV changes go through though? Or would just getting #1123 through -> updating the release (if not done yet) be sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated v20 release data with the latest consensus seg with #1123
b9284650be04df3538e6c6dba29b8eb0 pbta-cnv-consensus.seg.gz
I added the relative path so that we can run the code while running all the preprocessing steps of subtyping, so maybe we can add a logic to change to relative path or not within the if (params$base_run ==0)
OpenPBTA-analysis/analyses/focal-cn-file-preparation/02-add-ploidy-consensus.Rmd
Lines 48 to 58 in a6281c2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which scenario would you use the file in
analyses/copy_number_consensus_call/results
? When you usepbta-histologies-base.tsv
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we will rerun the consensus seg file module first so the latest consensus seg file can be used as input for the focal-cn module