This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
V20 CNV update part2: focal cnv and oncoprint rerun #1124
Merged
jaclyn-taroni
merged 5 commits into
AlexsLemonade:master
from
kgaonkar6:focalcn-oncoprint-update
Aug 11, 2021
Merged
V20 CNV update part2: focal cnv and oncoprint rerun #1124
jaclyn-taroni
merged 5 commits into
AlexsLemonade:master
from
kgaonkar6:focalcn-oncoprint-update
Aug 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jharenza
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The majority of the goi oncoprints did not change. ATRX deletion was recovered in two HGAT samples, one of which is annotated on pedcbio and we had been missing previously: https://pedcbioportal.kidsfirstdrc.org/patient?studyId=pbta_all&caseId=PT_7WT6P5M8
This looks good to me.
Also wanted to add here that all updates in status in this update were NA in previous CNV calls.
|
This was referenced Aug 5, 2021
Merged
This was referenced Aug 10, 2021
Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
Merging based on @jharenza 's review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
Just a rerun for focal-cn and oncoprint after #1123
What was your approach?
I added the conditions to use base histology in
focal-cn-preparation
module to run for subtyping when needed.What GitHub issue does your pull request address?
#1125
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
NA
Is there anything that you want to discuss further?
NA
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
yes
Results
What types of results are included (e.g., table, figure)?
tables
What is your summary of the results?
Rerun of focal calls and oncoprint from updated overlap #1123
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.