This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
According to Bo's rationale since ploidy is based on ControlFREEC using its corresponding CN would probably result in a better estimate of overall CN.
What was your approach?
Just a change in
OpenPBTA-analysis/analyses/copy_number_consensus_call/scripts/bed_to_segfile.R
Lines 119 to 128 in 2c1f5fa
to use controlfreec if available if not use cnvkit:
What GitHub issue does your pull request address?
#964
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
NA, it is just a 1 line code update
Is there anything that you want to discuss further?
Note: I have not added any downstream modules ( like I did in #987) in this PR since those downstream analysis are just re-runs and can come in after this PR is merged to master.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
yes
Results
What types of results are included (e.g., table, figure)?
tables
What is your summary of the results?
Here I'm comparing ( consensus_seg_annotated_cn_autosomes.tsv.gz + consensus_seg_annotated_cn_x_and_y.tsv.gz ) from the following versions of the files
The changes between using controlfreec and cnvkit are mainly as follows:
My underdstanding is controlfreec helps identifying consistent calls for multiple samples from the same participant ids where as cnvkit seems to be missing the call for 1 of the 2 multiple samples in the participants mentioned above.
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.