Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

PBTA Histologies v19 Part 2 of N: Update independent samples #1040

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

kgaonkar6
Copy link
Collaborator

@kgaonkar6 kgaonkar6 commented Apr 27, 2021

Purpose/implementation Section

What scientific question is your analysis addressing?

Rna summary modules needed for subtyping need to be updated because BS_JXF8A2A6 is removed as per #862. In this PR I'm re-running the independent-samples module.

Module Reason Brief Description output
independent-samples BS_JXF8A2A6 is removed as per #862 Generates independent specimen lists for WGS/WXS samples updated in #795 and #797 and comment results/independent-specimens.wgs.primary.tsv (included in data download)
results/independent-specimens.wgs.primary-plus.tsv (included in data download)
results/independent-specimens.wgswxs.primary.tsv (included in data download)
results/independent-specimens.wgswxs.primary-plus.tsv (included in data download)
results/independent-specimens.rnaseq.primary-plus-stranded.tsv(included in data download)
results/independent-specimens.rnaseq.primary-plus-polya.tsv (included in data download)

What was your approach?

Just re-run as part of the scripts/run-for-subtyping.sh in kgaonkar6:v19-release in #1028
Then create a new branch for module specific review:
git checkout v19-release analyses/independent-samples/

What GitHub issue does your pull request address?

#867

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

NA

Is there anything that you want to discuss further?

NA

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

yes

Results

What types of results are included (e.g., table, figure)?

tables

What is your summary of the results?

Some rna-seq sample selections have changed I believe because of the random selection

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@kgaonkar6 kgaonkar6 changed the title PBTA Histologies Part 2 of N: Update independent samples PBTA Histologies Part v19 2 of N: Update independent samples Apr 27, 2021
@kgaonkar6 kgaonkar6 changed the title PBTA Histologies Part v19 2 of N: Update independent samples PBTA Histologies v19 Part 2 of N: Update independent samples Apr 27, 2021
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I guess the html was out of date or something about the files changed to make it parse more logical columns...

@kgaonkar6
Copy link
Collaborator Author

broad_composition was added back , kf_visibility is a new field in the v19 pbta-histologies-base.tsv file.
However, parent_aliquot_id might not be needed let me check with Jo Lynne.

@kgaonkar6 kgaonkar6 requested a review from jashapiro April 28, 2021 18:25
@kgaonkar6
Copy link
Collaborator Author

Cols are updated in pbta-histologies-base.tsv to not include the new cols broad_composition and kf_visibility. The parent_aliquat_id is infact in v18 so it was accurately captured back.

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jashapiro jashapiro merged commit e167237 into AlexsLemonade:master Apr 28, 2021
@kgaonkar6 kgaonkar6 deleted the update-independent-samples branch May 11, 2021 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants