Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Update molecular subtyping file #702

Closed
jharenza opened this issue May 21, 2020 · 4 comments
Closed

Update molecular subtyping file #702

jharenza opened this issue May 21, 2020 · 4 comments
Labels

Comments

@jharenza
Copy link
Collaborator

What data file(s) does this issue pertain to?

https://github.com/AlexsLemonade/OpenPBTA-analysis/blob/master/analyses/molecular-subtyping-pathology/results/compiled_molecular_subtypes_with_pathology_feedback.tsv

What release are you using?

NA

Put a link to the relevant section of the OpenPBTA-manuscript here.

NA

Put your question or report your issue here.

Please add "Updated via OpenPBTA subtyping" to the Notes field for all rows in which subtypes were determined via OpenPBTA subtyping and perhaps "Updated via OpenPBTA subtyping and pathology assessment" (or similar) for tracking purposes.

cc @jaclyn-taroni and @baileyckelly

@jharenza jharenza added the data label May 21, 2020
@jaclyn-taroni
Copy link
Member

Do you have specific examples where the Notes column needs to be changed? Many rows already contain "Updated via OpenPBTA subtyping."

@jharenza
Copy link
Collaborator Author

Looks like LGG, for instance, are NA, but have been subtyped.

@jaclyn-taroni
Copy link
Member

I will defer to @baileyckelly and @allisonheath, as I know there are changes to how the clinical file are being generated (#656). I find "Updated via OpenPBTA subtyping" ambiguous – it could mean that the histology label changed, it could mean the addition of a subtype label. That's why I left it off of LGG.

@jharenza
Copy link
Collaborator Author

jharenza commented Dec 1, 2020

updated in #854

@jharenza jharenza closed this as completed Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants