-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] consecutive_digit_separator has no effect #96
Comments
Confirmed this affects both integer and floating point parsing, it seems like this corner case was never tested in our API tests, only the positive case. It seems there's something wrong with the |
Alexhuszagh
added a commit
that referenced
this issue
Sep 22, 2024
This addressed #96 and #97, fixing the lack of processing with consecutive digit separators by enhancing the internal logic, adds logic for internal and first digit separators to simplify logic and improve performance, fix unittests, and also make it so the errors are consistent by adding checks when formatting is enabled to ensure the correct logic is used. Closes #96 Closes #97
Alexhuszagh
added a commit
that referenced
this issue
Sep 24, 2024
This addressed #96 and #97, fixing the lack of processing with consecutive digit separators by enhancing the internal logic, adds logic for internal and first digit separators to simplify logic and improve performance, fix unittests, and also make it so the errors are consistent by adding checks when formatting is enabled to ensure the correct logic is used. Closes #96 Closes #97
Alexhuszagh
added a commit
that referenced
this issue
Sep 24, 2024
This addressed #96 and #97, fixing the lack of processing with consecutive digit separators by enhancing the internal logic, adds logic for internal and first digit separators to simplify logic and improve performance, fix unittests, and also make it so the errors are consistent by adding checks when formatting is enabled to ensure the correct logic is used. Closes #96 Closes #97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
First, thanks for the great library!
Perhaps I am doing this wrong, or misunderstanding what the flag is supposed to do, but it appears that
consecutive_digit_separator
has no effect on the results of parsing. Setting it tofalse
still allows multiple consecutive digit separators in the source string.Prerequisites
rustc 1.68.0 (2c8cc3432 2023-03-06)
lexical-util v0.8.5
lexical-parse-integer v0.8.6
lexical-parse-float v0.8.5
lexical-core v0.8.5
lexical v6.1.1
Test case
The text was updated successfully, but these errors were encountered: