Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize #8

Merged
merged 48 commits into from
Apr 26, 2024
Merged

Modernize #8

merged 48 commits into from
Apr 26, 2024

Conversation

RobThree
Copy link
Contributor

@RobThree RobThree commented Apr 26, 2024

This PR 'modernizes' the code and gets rid of a bunch of warnings and informational messages.

@RobThree
Copy link
Contributor Author

Next PR (based on this branch) lowers the required .Net version from 8.0 to NetStandard 2.0 which makes this library available for a much broader audience. I admit that some of the changes in this PR are a matter of preference or taste. Commits after b504e26 are an artifact of rebasing/merging and me messing something up, somewhere. Not sure what happened, but the net result should be a working branch / PR with the intended changes.

@AlexeyRaga AlexeyRaga merged commit 560e24d into AlexeyRaga:main Apr 26, 2024
1 check passed
@AlexeyRaga
Copy link
Owner

Legend! :)

@RobThree
Copy link
Contributor Author

image

@RobThree RobThree deleted the modernize branch April 26, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants