Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate sequence_id to BIGSERIAL #7

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

kchenery
Copy link
Contributor

Looks like your model already uses long. And the tests pass so I think this is ok as is.

@kchenery kchenery mentioned this pull request Apr 25, 2024
5 tasks
@RobThree
Copy link
Contributor

RobThree commented Apr 25, 2024

There are two sequence_id fields, the outbox table has one and the processes table has one, I assumed both should change. Also, shouldn't BIGINT be BIGSERIAL? The fields originally are SERIAL, so I thought it made sense to use BIGSERIAL? Or are there some Postgres intricacies I'm not aware of?

@kchenery
Copy link
Contributor Author

I had to check... (which I did before your comment BTW) and the way to change it is to change the datatype to BIGINT. It retains the "serial" part and when you check the types in GUIs etc it shows as BIGSERIAL.

@kchenery
Copy link
Contributor Author

Ive updated the process_managers.process table too.

@AlexeyRaga AlexeyRaga merged commit 0e86054 into AlexeyRaga:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants