Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select2 locales #31

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Add select2 locales #31

merged 1 commit into from
Jun 5, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 11, 2020

Alchemy does not depend on select2-rails anymore. So we need to ship the locales in here.

Alchemy does not depend on select2-rails anymore. So we need to ship the locales in here.
@robinboening
Copy link

I was just about to open an issue for this.

@tvdeyen anything holding this PR from being merged?

@afdev82
Copy link
Contributor

afdev82 commented Jun 5, 2021

I think it could be a good idea to merge also this PR and then pin a new major version that is compatible with Alchemy v5, because these translations are needed too (from v5.1.0: AlchemyCMS/alchemy_cms#1961)
What do you think?

@tvdeyen tvdeyen merged commit 7d04b02 into main Jun 5, 2021
@tvdeyen tvdeyen deleted the select2-translations branch June 5, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants