fix(Uploader): Handle HTML Errors during upload #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the upload fails because of Proxy errors (502, etc.) we cannot parse the html as json. We should display the actual error to the user, so they can report accordingly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3176 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 236 236
Lines 6360 6360
=======================================
Hits 6143 6143
Misses 217 217 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
approved these changes
Jan 27, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
If the upload fails because of Proxy errors (502, etc.) we cannot parse the html as json. We should display the actual error to the user, so they can report accordingly.
Checklist