Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install generator: Add option to force patched babel config #2495

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jun 21, 2023

The latest babel version has these plugins:

  • @babel/plugin-transform-class-properties
  • @babel/plugin-proposal-private-methods
  • @babel/plugin-proposal-private-property-in-object

already installed, but the webpacker installer still installs an old babel.config that includes these plugins.

Adding an option to the installer to force a patched babel config allows to run the installer on CI.

The latest babel version has these plugins:

- @babel/plugin-transform-class-properties
- @babel/plugin-proposal-private-methods
- @babel/plugin-proposal-private-property-in-object

already installed, but the webpacker installer still installs
an old babel.config that includes these plugins.

Adding an option to the installer to force a patched babel config
allows to run the installer on CI.
@tvdeyen tvdeyen requested a review from a team June 21, 2023 20:26
@tvdeyen tvdeyen merged commit a947305 into AlchemyCMS:6.1-stable Jun 21, 2023
@tvdeyen tvdeyen deleted the 6.1-fix-babel-config branch June 21, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant