Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract element ingredient migrator #2337

Merged
merged 2 commits into from
May 11, 2022

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 11, 2022

What is this pull request for?

Then we are able to call this from a data migration or rake task from apps.

Also ensure all ingredients get created during migration.

It might be the case that ingredients are defined on an element
that does not have a equivalent content.

We want to make sure that the element is exaclty is how it is defined in the elements.yml after the migration.

If the content could not be found, we just skip copying the data.

Checklist

tvdeyen added 2 commits May 11, 2022 11:19
Then we are able to call this from a data migration or rake task from apps.
It might be the case that ingredients are defined on an element
that does not have a equivalent content.

We want to make sure that the element is exaclty is how it is defined in the elements.yml after the migration.

If the content could not be found, we just skip copying the data.
@tvdeyen tvdeyen requested a review from mamhoff May 11, 2022 09:31
@tvdeyen tvdeyen merged commit ff68336 into AlchemyCMS:main May 11, 2022
@tvdeyen tvdeyen deleted the extract-element-ingredient-migrator branch May 11, 2022 09:47
tvdeyen added a commit that referenced this pull request May 11, 2022
…ator

Extract element ingredient migrator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants