New sortable page tree #2252
Merged
New sortable page tree #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f043056 to
3e1b43b
Compare
This uses sortablejs to handle dragndrop sorting of the page tree. There are lot of advantages over the old jQuery UI based nestedSortable. First and foremost it does not rebuild the whole tree, but just moves the one node.
The tree is now sortable
We do not use this anymore to sort the page tree. We use SortableJS instead.
This should help the exclude spec files from symlinked node_modules folders in the dummy app.
We need the current js packaghe to run specs, because it might be that we have changed them in the same branch.
3e1b43b to
4096039
Compare
Eager load pages public version, language and its site. This speeds up the page tree by 10!!
mamhoff
approved these changes
Mar 9, 2022
tvdeyen
added a commit
that referenced
this pull request
Mar 10, 2022
Backport #2252 from tvdeyen/sortable-page-tree
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
Mar 5, 2024
This has not been used since we changed to store page positions on Api::PagesController in v6.0 See: AlchemyCMS#2252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This uses the same mechanics and sortablejs library as we already do in the menus node tree.
This makes much fast reordering possible and we could get rid of the cumbersome and error prone
sort screen.
Notable changes
Pages are now sorted directly in the Page sitemap and not on a dedicated screen anymore. It also is much faster and
less brittle now. Also one less JQuery dependency
Checklist