Allow all possible args in tagged_with method #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2926970 to
bc42f3a
Compare
tvdeyen
reviewed
Nov 17, 2021
Previously, we only allowed tag names to be passed into the `tagged_with` method. This commit allows to take advantage of the interface gutentag has to offer, while being backwards compatible.
bc42f3a to
eafb1cd
Compare
|
I didn't notice the default value for |
tvdeyen
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only allowed tag names to be passed into the
tagged_withmethod. This commit allows to take advantage of the interface gutentag has to offer, while being backwards compatible.Closes #2208
If we agree on this proposed implementation I can add a couple of specs to cover the change.