Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make images non-executable #2176

Merged
merged 1 commit into from
Aug 16, 2021
Merged

make images non-executable #2176

merged 1 commit into from
Aug 16, 2021

Conversation

mensfeld
Copy link
Contributor

What is this pull request for?

Makes images and fonts non-executable.

Closes #2172

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change (irrelevant)

@tvdeyen
Copy link
Member

tvdeyen commented Aug 16, 2021

Thanks @mensfeld

Is there a reason why this is still in draft?

@mensfeld
Copy link
Contributor Author

@tvdeyen no, sorry. I wanted to switch it once all the specs passed (just in case).

@mensfeld mensfeld marked this pull request as ready for review August 16, 2021 08:25
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and thank you 🙏🏻

@tvdeyen tvdeyen added this to the 6.0 milestone Aug 16, 2021
@tvdeyen tvdeyen enabled auto-merge August 16, 2021 08:27
@tvdeyen tvdeyen disabled auto-merge August 16, 2021 09:24
@tvdeyen tvdeyen merged commit f2d7534 into AlchemyCMS:main Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-executable files set with executable permissions
2 participants